SYCLLowerIR: Migrate GlobalOffset tests to new PM#21463
Open
jsji wants to merge 3 commits intointel:syclfrom
Open
SYCLLowerIR: Migrate GlobalOffset tests to new PM#21463jsji wants to merge 3 commits intointel:syclfrom
jsji wants to merge 3 commits intointel:syclfrom
Conversation
Wrap GlobalVMap member in unique_ptr to make GlobalOffsetPass movable. ValueMap has deleted copy and move constructors, preventing the pass from being used with the new PassManager which requires movability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
YuriPlyakhin
reviewed
Mar 9, 2026
YuriPlyakhin
reviewed
Mar 9, 2026
Co-authored-by: Yury Plyakhin <yury.plyakhin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap GlobalVMap member in unique_ptr to make GlobalOffsetPass movable.
ValueMap has deleted copy and move constructors, preventing the pass
from being used with the new PassManager which requires movability.
Migrate GlobalOffset tests from legacy PM to new PM for NVPTX and AMDGPU targets. This change aligns with the upstream removal of -bugpoint-enable-legacy-pm (llvm/llvm-project#182320)
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com