[libspirv] Fix ptx bindless image builtins to be Itanium-compliant#21466
Open
wenju-he wants to merge 1 commit intointel:syclfrom
Open
Conversation
Fixed C preprocessor macros in image.cl to generate proper Itanium C++
ABI mangled names with substitution references (S0_) for repeated vector
types in SPIR-V bindless image array functions.
Previously, libclc-remangler undocumentedly corrected Itanium C++ ABI
violations. Now new symbol names match SYCL frontend output directly,
eliminating the need for libclc-remangler correction.
Example for __spirv_ImageArrayWrite<ulong, vec2<int>, vec2<int>>:
Before: _Z23__spirv_ImageArrayWriteImDv2_iDv2_iEvT_T0_iT1_
^^^^^ ^^^^^ - both spelled out
After: _Z23__spirv_ImageArrayWriteImDv2_iS0_EvT_T0_iT1_
^^^ - second uses S0_
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed C preprocessor macros in image.cl to generate proper Itanium C++ ABI mangled names with substitution references (S0_) for repeated vector types in SPIR-V bindless image array functions.
Previously, libclc-remangler undocumentedly corrected Itanium C++ ABI violations. Now new symbol names match SYCL frontend output directly, eliminating the need for libclc-remangler correction.
Example for _spirv_ImageArrayWrite<ulong, vec2, vec2>: Before: Z23__spirv_ImageArrayWriteImDv2_iDv2_iEvT_T0_iT1
^^^^^ ^^^^^ - both spelled out
After: Z23__spirv_ImageArrayWriteImDv2_iS0_EvT_T0_iT1
^^^ - second uses S0