Skip to content

Demo enhancements#37

Open
pezvi wants to merge 16 commits intomainfrom
restyle-demo-page
Open

Demo enhancements#37
pezvi wants to merge 16 commits intomainfrom
restyle-demo-page

Conversation

@pezvi
Copy link
Copy Markdown

@pezvi pezvi commented Mar 12, 2026

  • New 2 column layout
  • Restyled element presentation
  • Automatically add elements to the demo

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026

PR Preview Action v1.8.1

🚀 View preview at
https://internetarchive.github.io/elements/pr/pr-37/

Built to branch ghpages at 2026-03-30 22:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.36%. Comparing base (547c42c) to head (b6355b2).

Files with missing lines Patch % Lines
demo/story-template.ts 69.69% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #37       +/-   ##
===========================================
- Coverage   86.41%   76.36%   -10.05%     
===========================================
  Files           7       13        +6     
  Lines         368      495      +127     
  Branches       90      122       +32     
===========================================
+ Hits          318      378       +60     
- Misses         24       83       +59     
- Partials       26       34        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pezvi pezvi requested a review from jbuckner March 19, 2026 21:25
@pezvi pezvi marked this pull request as ready for review March 23, 2026 22:59
Copy link
Copy Markdown

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude: Overall this is a nice improvement — the auto-discovery via import.meta.glob, sidebar nav with scroll-spy, collapsible details panel, and copy buttons are all solid additions. The test file is thorough. A few comments inline.

IA Jim added 2 commits March 30, 2026 15:04
- base tag name on file name
- click listener cleanup
- adds semantic 'expanded' class string
- console warns on clipboard failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants