WEBDEV-8140 Add range and number options for story style settings#47
Open
latonv wants to merge 7 commits into
Open
WEBDEV-8140 Add range and number options for story style settings#47latonv wants to merge 7 commits into
range and number options for story style settings#47latonv wants to merge 7 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 78.75% 79.66% +0.90%
==========================================
Files 16 16
Lines 645 659 +14
Branches 168 177 +9
==========================================
+ Hits 508 525 +17
+ Misses 95 90 -5
- Partials 42 44 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only two available types for style settings in element stories are
textandcolor. Whiletextis already quite general and can handle most cases, for some kinds of numeric style rules it can be helpful to constrain the range or units for the sake of an expressive demo.This PR makes two new types of style setting available:
range(which renders a range slider & value readout) andnumber(which renders a numeric spinner). Additionally, arangestyle is added to theia-combo-boxstory and anumberstyle is added to theia-dropdown-search-barstory to demonstrate their usage and visual results.