[store] Remove intermediate store interface #1411
Draft
the-glu wants to merge 2 commits intointeruss:masterfrom
Draft
[store] Remove intermediate store interface #1411the-glu wants to merge 2 commits intointeruss:masterfrom
the-glu wants to merge 2 commits intointeruss:masterfrom
Conversation
…merge datastoreutils into datastore
the-glu
force-pushed
the
remove_store_interface
branch
from
88e1e6c to
d02fabe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow #1409
It remove the intermediate 'Store' interface.
The only potential reason for it was the tests, as DB is mocked (in RID only), but those tests are also ran with real database, so I just removed the mock as well.