[monitoringlib] Set ConnectionResetError as retryable #1310
+73
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) | ||
| # ...and this may be retryable | ||
| retryable = True | ||
| elif "ConnectionResetError" in str(e): |
Member
There was a problem hiding this comment.
While I'm sure this will work fine most of the time practically, can we make this more robust by checking the actual type rather than looking in the string representation? And, perhaps checking the message for "Connection reset by peer" if we always see that in the errors we think are valid to retry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #1298 to avoid conflicts on the same code area.
Fix #1306 by making ConnectionResetError retryable.
Not tested, as the change is simple and creating an environment with random connection reset is complex.