chore(dev): add .ai/ shared layer for AI customization#296
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…move performance, update security) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report
File CoverageNo changed files found. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughCentralizes AI customization into a shared ChangesShared AI Customization Layer
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ioncache
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.ai/instructions/code-review.md:
- Around line 62-66: The listed instruction files paragraph incorrectly
references a non-existent token "performance"; update the list so it matches the
migrated files: remove "performance", change "jsdoc" to "jsdoc-tsdoc" if
present, and ensure "plan-writing" is included alongside "code-complexity",
"code-review", "comments", "security", and "unit-tests"; edit the paragraph that
contains the word "performance" (the instruction files list) to exactly mirror
the migrated-files list from the plan.
In @.ai/skills/ai-add-instruction.md:
- Around line 56-58: The fenced code block showing "@.ai/instructions/<name>.md"
should include a language identifier (e.g., "text" or "markdown") to improve
clarity and syntax highlighting; update the block in
.ai/skills/ai-add-instruction.md (the triple-backtick block containing
"@.ai/instructions/<name>.md") to start with ```text or ```markdown instead of
bare ``` so the snippet is explicitly annotated.
In @.ai/skills/ai-add-prompt.md:
- Around line 49-50: The fenced code block containing the line
"@.ai/prompts/<name>.md" is missing a language identifier; update the
triple-backtick fence to include a language such as "text" or "markdown" (e.g.,
change ``` to ```text) so the block is explicitly typed and renders correctly in
markdown processors.
In @.ai/skills/ai-add-skill.md:
- Around line 52-53: The fenced code block that currently contains the literal
line "@.ai/skills/<name>.md" should include a language identifier for clarity;
update the triple-backtick fence so it starts with ```text (or ```markdown)
instead of just ``` to produce "```text" followed by the "@.ai/skills/<name>.md"
line and the closing triple-backticks, ensuring the snippet is identifiable as
plain text in the skills file.
In `@docs/plans/008-ai-customization-shared-layer.md`:
- Around line 138-140: Update the fenced code block that currently reads ```
followed by "@.ai/skills/plan-writing.md" to include the language specifier
"markdown" (i.e., change the opening fence to ```markdown) so the block is
lint-compliant; locate the code fence in the
docs/plans/008-ai-customization-shared-layer.md content where the snippet
"@.ai/skills/plan-writing.md" is shown and modify the opening triple backticks
accordingly.
- Around line 60-68: The fenced examples for the Claude skill and Claude prompt
are missing language specifiers which harms syntax highlighting; update the two
code fences that show `@.ai/skills/<name>.md` and `@.ai/prompts/<name>.md` so
they start with ```markdown (i.e., add the "markdown" language identifier to the
opening backticks for the snippets referencing `.claude/skills/<name>.md` and
`@.ai/skills/<name>.md`/`@.ai/prompts/<name>.md`) to satisfy linters and enable
proper highlighting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 10621e5f-5177-4e0e-ba0c-f00e045bdb01
📒 Files selected for processing (33)
.ai/README.md.ai/instructions/code-complexity.md.ai/instructions/code-review.md.ai/instructions/comments.md.ai/instructions/jsdoc-tsdoc.md.ai/instructions/plan-writing.md.ai/instructions/security.md.ai/instructions/unit-tests.md.ai/skills/ai-add-instruction.md.ai/skills/ai-add-prompt.md.ai/skills/ai-add-skill.md.ai/skills/plan-writing.md.claude/settings.json.claude/skills/ai-add-instruction.md.claude/skills/ai-add-prompt.md.claude/skills/ai-add-skill.md.claude/skills/plan-writing.md.github/instructions/code-complexity.instructions.md.github/instructions/code-review.instructions.md.github/instructions/comments.instructions.md.github/instructions/jsdoc-tsdoc.instructions.md.github/instructions/jsdoc.instructions.md.github/instructions/performance.instructions.md.github/instructions/plan-writing.instructions.md.github/instructions/security.instructions.md.github/instructions/unit-tests.instructions.md.github/skills/ai-add-instruction/SKILL.md.github/skills/ai-add-prompt/SKILL.md.github/skills/ai-add-skill/SKILL.md.github/skills/plan-writing/SKILL.md.gitignoreCLAUDE.mddocs/plans/008-ai-customization-shared-layer.md
💤 Files with no reviewable changes (2)
- .github/instructions/performance.instructions.md
- .github/instructions/jsdoc.instructions.md
- Update code-review.md to reference jsdoc-tsdoc (not jsdoc) and plan-writing, remove stale performance reference - Add text language identifier to fenced blocks in maintenance skills and plan doc Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Creates a
.ai/directory as a single source of truth for all AI customizationcontent (instructions, skills, prompts). Both GitHub Copilot and Claude Code
now reference this shared layer through thin wrapper files, eliminating
duplication and ensuring both AI systems always follow the same standards.
Details
.ai/instructions/— 7 shared instruction files (code-complexity,code-review, comments, jsdoc-tsdoc, plan-writing, security, unit-tests),
migrated from
.github/instructions/with Copilot frontmatter stripped.ai/skills/— Shared skill files forplan-writingand three newmaintenance skills (
ai-add-instruction,ai-add-prompt,ai-add-skill).github/instructions/and.github/skills/— Converted to thinwrappers: frontmatter preserved, body replaced with
#file:reference to.ai/.claude/skills/— New Claude Code thin wrappers using@import syntaxCLAUDE.md— Conventions section now uses@importlines instead ofinline bullet points
ai-add-instruction,ai-add-prompt, andai-add-skilldetect which AI systems are active and auto-generate thecorrect thin wrappers when new content is added to
.ai/Related Tickets and/or Pull Requests
docs/plans/008-ai-customization-shared-layer.md🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation