feat(datetime): add wheel part to ion-picker-column #30934
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
thetaPC
requested review from
OS-jacobbell and
brandyscarney
and removed request for
OS-jacobbell
brandyscarney
approved these changes
Jan 26, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good! Some optional changes requested. 🚀
Comment on lines
+77
to
+78
| .custom-grid-wheel::part(wheel):focus, | ||
| ion-picker-column:focus { |
Member
There was a problem hiding this comment.
Can we add a comment that the 1st selector applies to the month/year picker and the wheel style datetime and the 2nd selector applies to the time picker?
| }); | ||
|
|
||
| test.describe(title('CSS shadow parts'), () => { | ||
| test('should be able to customize wheel part', async ({ page }, testInfo) => { |
Member
There was a problem hiding this comment.
Optional: should we break this up into the different ways where you can customize the wheel part?
- Month/year picker
- Wheel style (
prefer-wheel) picker - Time picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30420
What is the current behavior?
It is not possible to style the
ion-picker-columnwithinion-datetime. This leads to developers unable to style it for any states like focus.What is the new behavior?
wheelpart toion-picker-columnwhen it's withinion-datetime.Does this introduce a breaking change?
Other information
Preview