Skip to content

[Repo Assist] Add regression test for unnecessary parens in chained method call (issue #1362) #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Repo Assist] Add regression test for unnecessary parens in chained method call (issue #1362) #1483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f77b5
Add regression test for issue #1362: unnecessary parens in chained me…
Feb 26, 2026
5d2b360
ci: trigger CI checks
github-actions[bot] Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3651,6 +3651,24 @@ let private removeUnnecessaryParenthesesTests state =
(Diagnostics.expectCode "FSAC0004")
selector

// Regression test for https://github.com/ionide/FsAutoComplete/issues/1362
// Parens around a float literal in a chained method call are necessary:
// bg.lighten(0.2).hexa ()
// Removing them would produce invalid code:
// bg.lighten 0.2.hexa ()
testCaseAsync "Keep parens around float literal argument in chained method call (issue #1362)"
<| CodeFix.checkNotApplicable
server
"""
type C(v: float) =
member _.lighten(x: float) = C(v + x)
member _.hexa() = v.ToString()
let bg = C(0.5)
bg.lighten((0.2)$0).hexa ()
"""
Diagnostics.acceptAll
selector

])

let tests textFactory state =
Expand Down
Loading