[Repo Assist] test: add test case for FSAC0002 false positive in nullable join clause (issue #824)

[github-actions]

🤖 This is an automated PR from Repo Assist.

Summary

Adds a test case documenting the false positive FSAC0002 diagnostic that occurs when using the nullable join operator (=?) in a query expression (issue #824).

Problem

When writing a query expression like:

query {
  for row1 in table1 do
  join row2 in table2 on (row1.Column1 =? row2.Column2)
  select (row1, row2)
}

FSAC incorrectly reports row1 as a redundant qualifier (FSAC0002). The "Remove redundant qualifier" code fix appears, but applying it would break the code since row1 is necessary in this context.

Root Cause

This is an upstream bug in FCS: FSharp.Compiler.EditorServices.SimplifyNames.getSimplifiableNames incorrectly returns row1.Column1 as simplifiable in a nullable join clause. FSAC simply reports what FCS tells it, so the fix needs to happen upstream.

Change

Added a test case using itestCaseAsync (ignored — does not run, does not fail CI) to the RemoveRedundantQualifier test list. This approach is appropriate per the project convention:

Used to mark issues & shortcomings in CodeFixes, but without any (immediate) intention to fix (vs. pending → marked for fixing)

When the upstream FCS bug is fixed, itestCaseAsync should be changed to testCaseAsync to activate the regression test.

Test Status

✅ Build: dotnet build test/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj -f net8.0 — succeeded (0 warnings, 0 errors)
✅ Format: dotnet fantomas — file was unchanged
ℹ️ The new test itself is ignored (itestCaseAsync) so it does not run; it serves as documentation of the expected behavior.

Closes #824

Generated by Repo Assist for issue #824

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@afb00b92a9514fee9a14c583f059a03d05738f70

[Krzysztof-Cieslak]

/repo-assist unignore the test, we want to check if it's passing

[github-actions]

Commit pushed: 667c435

Generated by Repo Assist

[github-actions]

🤖 This is an automated response from Repo Assist.

Done! I've changed itestCaseAsync → testCaseAsync for the "doesn't remove necessary qualifier in nullable join clause (issue #824)" test. CI will now run it and we'll see whether it passes (meaning the upstream FCS bug is fixed) or fails (meaning it still needs to be fixed upstream).

Generated by Repo Assist for issue #1484

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@afb00b92a9514fee9a14c583f059a03d05738f70