Fixed missing prefix on stops.txt$parent_station on merge_gtfs() method#93
Merged
Conversation
Contributor
Author
Collaborator
|
thanks, @gmatosferreira . nice catch and simple fix ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

According to GTFS official documentation, stops.txt has a column
parent_stationthat references astops.txt$stop_id. However, the methodgtfstools::merge_gtfs()only considers the columns that end with_idwhen applying theprefixparameter, which is generating an invalidparent_stationcolumn in the merged GTFS when this column exists.gtfstools/R/merge_gtfs.R
Line 161 in 6bb51d8
With a simple refactoring to include
parent_stationin theid_colsfilter fixes this.