Adds Ansible Playbook for deploying multiple docker compose instances.#348
Open
hey-johnnypark wants to merge 8 commits intodevelopfrom
Open
Adds Ansible Playbook for deploying multiple docker compose instances.#348hey-johnnypark wants to merge 8 commits intodevelopfrom
hey-johnnypark wants to merge 8 commits intodevelopfrom
Conversation
jekutzsche
requested changes
Sep 15, 2021
Member
jekutzsche
left a comment
jekutzsche
left a comment
There was a problem hiding this comment.
I am irritated by all the copying of the certificate and key files. Wouldn't it be better to work with only one directory or with links here, so that it is less error-prone later when checking or exchanging the certificates.
Comment on lines
+1
to
+2
| sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose | ||
| sudo chmod +x /usr/local/bin/docker-compose No newline at end of file |
Member
There was a problem hiding this comment.
Wouldn't it make more sense to use https://github.com/docker/compose/releases/latest/download/docker-compose… so that you don't always have to maintain the version?
Comment on lines
+72
to
+74
| vars: | ||
| cert: "{{ nginx.cert}}" | ||
| key: "{{ nginx.key}}" |
Member
There was a problem hiding this comment.
I could not find anything where these variables are used.
jekutzsche
force-pushed
the
develop
branch
7 times, most recently
from
1a856bc to
7ed21c6
Compare
jekutzsche
force-pushed
the
develop
branch
4 times, most recently
from
ceb58c0 to
c1e8368
Compare
jekutzsche
force-pushed
the
develop
branch
8 times, most recently
from
7f0b9b1 to
272c2ac
Compare
jekutzsche
force-pushed
the
develop
branch
7 times, most recently
from
079e7dd to
bbabf0a
Compare
jekutzsche
force-pushed
the
develop
branch
2 times, most recently
from
6ae7c6b to
9c2857d
Compare
jekutzsche
force-pushed
the
develop
branch
2 times, most recently
from
1f556c6 to
eef57e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jekutzsche ,
this feature enables the installation of n - number of clients using Ansible.