fix: catch floating addFilesAsync rejections and bubble them up to main promise#455
Closed
pieh wants to merge 1 commit intoisaacs:mainfrom
Closed
fix: catch floating addFilesAsync rejections and bubble them up to main promise#455pieh wants to merge 1 commit intoisaacs:mainfrom
pieh wants to merge 1 commit intoisaacs:mainfrom
Conversation
5 tasks
pieh
force-pushed
the
fix/uncaught-rejection-on-files
branch
from
9883cfe to
88515be
Compare
PR-URL: isaacs#455 Credit: @pieh Close: isaacs#455 Reviewed-by: @isaacs
isaacs
force-pushed
the
fix/uncaught-rejection-on-files
branch
from
9883cfe to
01082a4
Compare
Owner
|
Nice! This is obviously 100% correct. Published on 7.5.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've hit case where FS errors originating from
addFilesAsyncfunction calls were not catchable and were causing unhandled rejections crashes (ref: netlify/build#6990).I prepared this optimistic fix together with test cases for them (that do fail without code change)
--edit:
I'll push just tests temporarily to show those fail without changes)Well, I guess tests don't run my changes, so it just seems to test
main🤷