Skip to content

explorer: fix halo terrain occlusion via scene.globe.depthTestAgainstTerrain (v2) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdhyee wants to merge 1 commit into from
Closed

explorer: fix halo terrain occlusion via scene.globe.depthTestAgainstTerrain (v2) #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions explorer.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,14 @@ viewer = {
terrain: Cesium.Terrain.fromWorldTerrain()
});

// Surface-marker primitives (h3 clusters, sample dots) sit at altitude=0;
// World Terrain elevation otherwise occludes them, producing crescent halos
// and disappearing dots over hills (#180 regression). Disabling terrain
// depth-test draws primitives over terrain while preserving globe-ellipsoid
// occlusion (back-side primitives stay hidden) and pick correctness — unlike
// per-primitive `disableDepthTestDistance: Infinity`, which broke both.
v.scene.globe.depthTestAgainstTerrain = false;

// URL deep-link state (must be set before globalRect/once block reads it)
v._globeState = { mode: 'cluster', selectedPid: null };
v._initialHash = readHash();
Expand Down
Loading