Open
Conversation
- Convert shadeless/material properties to 2.8 nodes - combined 2 files into 1 (I have no idea how to run them without installing the addon as 2 files; it's just easier. 2nd file is really small anyway)
Owner
|
Nice, thank you! I'll take a look at it in the next few days. |
Owner
|
I took a look at it, and it's a good start. The addon loads and the panel and calculations work after changing the bl_info version, but sadly, there's still something missing to get it to actually write the values to vertex colors. I'll need to take a look at the API doc and see what changed about vertex colors. Edit: Never mind, it looks like the panel is missing some things and calculations result in vectors filled with 1s. Still looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installing the addon as 2 files; it's just easier. 2nd file is really
small anyway)
Notes:
I suggest you create a 2.8 branch and merge this PR into there, then see if there are any other issues.