Conversation
> yup. i had to remove validations from Authentication (due to race > conditions caused by circular dependencies and this code: > https://github.com/eurucamp/eurucamp-activities-2013/blob/master/app/models/user.rb#L21 > (btw, omniauth part of this app was copied from our call4papers app)) ) > and now these tests are failing. > Feel free to mark all of them as pending. @pieta
This reverts commit 32b3012.
Signed-off-by: Alex Coles <alex@alexbcoles.com>
Signed-off-by: Alex Coles <alex@alexbcoles.com>
Signed-off-by: Alex Coles <alex@alexbcoles.com>
* Bump related Sprockets and asset pipeline gems * Bump OmniAuth to compatible version * Bump Draper to compatible (pre-release) version * Add activemodel-serializers-xml and rails-controller-testing for backwards compatibility.
Signed-off-by: Alex Coles <alex@alexbcoles.com>
Shelly Cloud is no in operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.