feat: add ability to remove whole deleted option#329
Open
Edmilson-C wants to merge 3 commits intoisneezy:masterfrom
Open
feat: add ability to remove whole deleted option#329Edmilson-C wants to merge 3 commits intoisneezy:masterfrom
Edmilson-C wants to merge 3 commits intoisneezy:masterfrom
Conversation
Owner
|
Hi @Edmilson-C, thank you for your contribution, could you please make this behavior optional (opt-in)? |
Author
|
Hello @isneezy, I did the change that you asked. |
Owner
|
That's Awesome, one more thing. Please update the documentation. Specifically this file |
Author
|
@isneezy Hello, it's done |
Author
|
Hi @isneezy, have you seen the change yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting an option, if input is multiple, delete the whole option, instead of deleted letter by letter