Skip to content

Conversation

@BR0kEN-
Copy link

@BR0kEN- BR0kEN- commented Mar 1, 2016

  • Removed redundant functionality
  • Logic improvements
  • Docs improvements
  • Fixing coding standards
  • Added todo's

In total - not bad idea. But implementation - not. This tool needs more love to be ready for production. I cannot advise this to anyone for now.

@Gormartsen
Copy link
Member

Tnx with cleaning code help.

@Gormartsen Gormartsen self-assigned this Mar 2, 2016
@Gormartsen
Copy link
Member

@BR0kEN- nice changes
I briefly checked visually this PR and it looks good, but I want to test them first.

Will do as soon as I get free time.

I want to finish original version first:

https://github.com/Gormartsen/backdrop/tree/1.x/core/modules/render_cache

Then finally back port all features to drupal 7.

Again, I appreciate your help and will apply your PR as soon as I get time to test it.

@btopro
Copy link

btopro commented Mar 22, 2016

@BR0kEN- tried ur fork; appears that if devel is enabled but debug variable is disabled it throws notices

@btopro
Copy link

btopro commented Mar 22, 2016

see: #6 which fixes issues in the PR

@Gormartsen
Copy link
Member

Thank you.

I will look into it.

Regards,
Gor Martsen
@Gormartsen

On Mar 22, 2016, at 4:33 PM, Bryan Ollendyke notifications@github.com wrote:

see: #6 which fixes issues in the PR


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants