Enhancement/kotlin transition#195
Open
yatiksihag01 wants to merge 2 commits intoitsdrnoob:dev/2.4.0from
Open
Conversation
…d DataUsageViewModel and UsageDataHelperImpl for single responsibility, optimized UsageDataAdapter with AsyncListDiffer and click listeners in AppDataUsageFragment, replaced AsyncTask with Kotlin coroutines, and added debug suffix for debug package.
Owner
|
Great, most of the previous issues were addressed but I've still noticed some issues.
Let me know what you think. |
Author
Hi @itsdrnoob , can you please explain a bit about first issue? |
Owner
Sure. So basically both user app list as well as system apps list has to be refreshed on events like manual refresh in AppDataUsageFragment and session/type filter change, so that if opened, the up-to-date data is readily available in SystemDataUsageFragment. This was done by accessing the Also, here are some other details I've observed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #190 which was closed due to change in base branch. This PR also solved all the unexpected behaviour mentioned here.