Replace in link text and link target#12
Open
bdabelow wants to merge 4 commits intoivanbicalho:mainfrom
Open
Conversation
Replacements are being made in text and target of hyperlinks, including in header and footer.
bdabelow
force-pushed
the
replace-in-links
branch
from
01f8484 to
d374e42
Compare
ivanbicalho
reviewed
Apr 4, 2023
src/python_docx_replace/paragraph.py
Outdated
| if key in self.p.text: | ||
| self._complex_replace_key(key, value) | ||
| # Make replacements in hyperlink texts | ||
| for link in self.p._element.xpath(".//w:hyperlink"): |
Owner
There was a problem hiding this comment.
Instead of having this code here, I think it'd be better to move it to a specific method, like self._replace_hyperlinks(key, value)
Owner
|
Hey @bdabelow, I was checking your code to merge it, but I found new issues with the current approach. I fixed one, but there are more, for example, this code is not right: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacements are being made in text and target of hyperlinks, including in header and footer.
Fixes #8