Fix on node 18#670
Open
perrin4869 wants to merge 2 commits intoivogabe:masterfrom
Open
Conversation
|
any updates on this issue? |
|
@haoadoreorange Could you please look and merge? |
This was referenced Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module is broken on node 18 due to mozilla/source-map#349 and
node.jsadding a globalfetch.I found some helpful discussion here too: terser/terser#1164
They updated to the beta release
It would be awesome if this could be backported to v5 as well.
Thanks!