fix: clear Zizmor 1.25 findings (github-app + online-audit 401)#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two Zizmor 1.25.2 findings blocking the zizmor-action bump (#64):
tag-release.yml: narrow the App token topermission-contents: write(least privilege for checkout + Git Data API content/ref/tag writes).security.yml: setonline-audits: falsewith an explanatory comment. Theimpostor-commitonline audit returns 401 on cross-repo tag lookups under 1.25.2 even with the action's default${{ github.token }}; disabling keeps the required gate deterministic and matches the documented local command (which already uses--no-online-audits).Does NOT bump the
zizmor-actionSHA — PR #64 carries that and will rebase onto this fix to validate the end-to-end v0.5.6 path.Test Plan
zizmor . --min-severity medium --min-confidence medium --no-progress --color never --no-online-audits→ no findings (github-app cleared) under engine 1.25.2./scripts/check-inline-sync.shpasses./scripts/lint-workflow-call.shpassesbats tests/→ 204 passing, 0 failuresFixes #68.