fix: Issue 89 resolved #2602 - upgrade lwjglx (jme3)#2645
fix: Issue 89 resolved #2602 - upgrade lwjglx (jme3)#2645JNightRider wants to merge 1 commit intojMonkeyEngine:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a known issue affecting Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the lwjgl3-awt dependency to org.jmonkeyengine:lwjgl3-awt:0.2.4 in gradle/libs.versions.toml. This change is intended to fix an issue with LwjglCanvas on Windows, as described in the PR. The update is straightforward and no issues were found with this change.
This pull request updates the lwjgx version to match the version released by jme3 (v0.2.4), as mentioned in issue #2602. The lwjgx team released the patch for this issue (LWJGLX/lwjgl3-awt@b7270e9), but there were some issues with its release, so jme3 is now handling it.
LwjglCanvas should now work on Windows...