Skip to content

fix: Issue 89 resolved #2602 - upgrade lwjglx (jme3)#2645

Open
JNightRider wants to merge 1 commit intojMonkeyEngine:masterfrom
JNightRider:fix/update-lwjglx
Open

fix: Issue 89 resolved #2602 - upgrade lwjglx (jme3)#2645
JNightRider wants to merge 1 commit intojMonkeyEngine:masterfrom
JNightRider:fix/update-lwjglx

Conversation

@JNightRider
Copy link
Contributor

This pull request updates the lwjgx version to match the version released by jme3 (v0.2.4), as mentioned in issue #2602. The lwjgx team released the patch for this issue (LWJGLX/lwjgl3-awt@b7270e9), but there were some issues with its release, so jme3 is now handling it.

LwjglCanvas should now work on Windows...

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a known issue affecting LwjglCanvas functionality on Windows by updating a critical dependency. The lwjgl3-awt library has been upgraded to a newer version, now managed by the jMonkeyEngine project, to incorporate necessary fixes and ensure better compatibility and stability for the canvas component.

Highlights

  • Dependency Upgrade: The lwjgl3-awt dependency has been upgraded from version 0.2.3 to 0.2.4.
  • Dependency Relocation: The lwjgl3-awt dependency's group ID has been changed from org.lwjglx to org.jmonkeyengine, reflecting its new maintenance by jme3.
  • Issue Resolution: This upgrade is intended to resolve issue Encountered an issue when using LwjglCanvas in version 3.10.0-alpha1 #2602, specifically addressing problems with LwjglCanvas on Windows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the lwjgl3-awt dependency to org.jmonkeyengine:lwjgl3-awt:0.2.4 in gradle/libs.versions.toml. This change is intended to fix an issue with LwjglCanvas on Windows, as described in the PR. The update is straightforward and no issues were found with this change.

@yaRnMcDonuts yaRnMcDonuts added this to the v3.10.0 milestone Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants