This repository was archived by the owner on Jul 22, 2019. It is now read-only.
Replace lateinit binding of dependencies with constructor-injection#1292
Open
geoand wants to merge 1 commit intojabbink:developfrom
Open
Replace lateinit binding of dependencies with constructor-injection#1292geoand wants to merge 1 commit intojabbink:developfrom
geoand wants to merge 1 commit intojabbink:developfrom
Conversation
It is considered good practice in Spring applications to use constructor injection whenever possible (the main reasons are better readability and testability of classes). Moreover, starting with 4.3.RC1 version of Spring, the @Autowired annotation is no longer needed when a class has a single constructor. Leveraging this fact along with Kotlin's very concise constructor syntax yields some nice readability improvements
itsmoonrack
approved these changes
Oct 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is considered good practice in Spring applications to use
constructor injection whenever possible (the main reasons are better
readability and testability of classes).
Moreover, starting with 4.3.RC1 version of Spring, the @Autowired
annotation is no longer needed when a class has a single constructor.
Leveraging this fact along with Kotlin's very concise constructor
syntax yields some nice readability improvements