Enable ineffassign linter#2472
Merged
jackc merged 1 commit intojackc:masterfrom Jan 24, 2026
Merged
Conversation
analytically
reviewed
Jan 9, 2026
| } | ||
| decryptedKey, decryptedError = x509.DecryptPEMBlock(block, []byte(sslpassword)) | ||
| // Should we also provide warning for PKCS#1 needed? | ||
| if decryptedError != nil { |
Contributor
Author
There was a problem hiding this comment.
Ok i ignored this case to avoid weird possible bugs
This also fixes all warnings about it.
guerinoni
force-pushed
the
ineffassign
branch
from
6eb0056 to
ed7e5fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes all warnings about it.