perf: use native sync.Pool for connection freelists#192
Draft
kislaykishore wants to merge 1 commit intojacobsa:masterfrom
Draft
perf: use native sync.Pool for connection freelists#192kislaykishore wants to merge 1 commit intojacobsa:masterfrom
kislaykishore wants to merge 1 commit intojacobsa:masterfrom
Conversation
This replaces the custom lock-guarded freelist implementation with native sync.Pool allocations for buffer.InMessage and buffer.OutMessage, significantly reducing mutex contention. Benchmarks (16 CPUs): Old (freelist + Mutex): BenchmarkGetPutInMessage-16 6543512 182.5 ns/op BenchmarkGetPutOutMessage-16 6632773 185.3 ns/op New (sync.Pool): BenchmarkGetPutInMessage-16 551016232 2.125 ns/op BenchmarkGetPutOutMessage-16 531943348 2.231 ns/op Performance improved by ~85x under high concurrency.
kislaykishore
force-pushed
the
sync-pool-perf
branch
from
918788a to
08fba92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom lock-guarded freelist implementation for message buffers with native
sync.Poolallocations, significantly reducing mutex contention and GC pressure.Benchmark Results (16 CPUs)
Old Implementation (Custom Freelist + Mutex):
New Implementation (sync.Pool):
This represents an ~85x performance improvement for message buffer allocations under high concurrency. Note that
sync.Poolalso automatically reclaims memory during GC, preventing long-lived memory high-water marks.