Skip to content

Conversation

@jaevans
Copy link
Owner

@jaevans jaevans commented May 6, 2025

No description provided.

@jaevans jaevans requested a review from Copilot May 6, 2025 15:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the git command by moving it as a subcommand under the bump command while retaining the old git command as a deprecated command on the root.

  • Migrate the git command to be accessed via bumpCmd
  • Introduce a deprecated git command on the root and add new tests for tag retrieval functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
cmd/root.go Added subcommands for deprecatedGitCmd, bumpCmd, and SortCmd.
cmd/git_test.go Introduced tests for getTagsStrings with valid and empty tag cases.
cmd/git.go Created a deprecatedGitCmd and updated flag initialization.
cmd/bump.go Updated the command hierarchy to register gitCmd under bumpCmd.
Comments suppressed due to low confidence (1)

cmd/git_test.go:134

  • [nitpick] Consider renaming test functions to follow standard Go naming conventions (e.g., TestGetTagsStringsValidVersions) for improved readability.
func Test_GetTagsStrings_ValidVersions(t *testing.T) {

@jaevans jaevans force-pushed the move-git-to-bump-subcmd branch from 4e0aa31 to 8b8e306 Compare May 6, 2025 15:25
@jaevans jaevans self-assigned this May 6, 2025
@jaevans jaevans merged commit 23e0c7c into main May 6, 2025
1 check passed
@jaevans jaevans deleted the move-git-to-bump-subcmd branch June 24, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants