Remove skipped tasks from the stack.#442
Open
Michael-Downton wants to merge 1 commit intojakejs:mainfrom
Open
Conversation
_initInvocationChain pushes the task to the stack and is called on task.invoke and task.execute. When a task skips (like a file task does) the task.run() checks to see if it needs to be evaluated and if not, skips the task. Unfortunately it leaves the task on the stack causing some weird finished task messaging and can lead to early bailing. Lets just pop the task from the stack when skipped.
Author
|
Issue for pr: #441 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_initInvocationChain pushes the task to the stack and is called on task.invoke and task.execute. When a task skips (like a file task does) the task.run() checks to see if it needs to be evaluated and if not, skips the task. Unfortunately it leaves the task on the stack causing some weird finished task messaging and can lead to early bailing.
Lets just pop the task from the stack when skipped.