You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not very happy with the color choices. Colors like unemphasizedSelectedTextBackgroundColor have a very specific function, and should not be used for unrelated things. Either use a custom color (use asset catalog to create custom color with light / dark mode), or use a color that is suitable from a semantic point of view (is there a system grid color?)
It's a good point. I had tested gridColor but it was very dark and wasn't being correctly color mixed with the Desktop picture - this now seems to be the case with unemphasizedSelectedTextBackgroundColor which does't get mixed in Dark Mode. Changes in 10.14.2 perhaps?
I have switched to gridColor (it seems to be working correctly now) for the grid lines and kept the unused table sections as alternatingContentBackgroundColor as it does the right thing in Dark Mode and adapts to the Desktop Picture.
I'd love to have dark mode on my Table Tool app. Any plans on updating the app to support dark mode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed table view to use system colors to provide support for Mojave Dark Mode.
