fix: pinned panel shows all agents, no crash — fixed height via isPinned (#141), v0.3.3#148
Open
fix: pinned panel shows all agents, no crash — fixed height via isPinned (#141), v0.3.3#148
Conversation
…sh and shows all agents (#141), v0.3.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141. Previous attempt (PR #147) crashed with SIGABRT — minHeight constraint fought AppKit's layout engine causing an unresolvable constraint abort.
Root cause: NSPanel doesn't propose a size to SwiftUI, so the ScrollView collapsed. The correct fix is to have SwiftUI own the height when in panel mode via a fixed .frame(height: 540) — but only in panel mode (not popover mode where NSPopover owns the height).
Change: PopoverView body now uses .frame(width: 320, height: isPinned ? 540 : nil). When pinned, SwiftUI sizes itself to exactly 540pt. When in popover, nil lets the popover's contentSize control height as before. No constraint conflicts, no crash.
Also reverts the minHeight:440 that caused the crash.