feat: testing, credo and dialyzer#1
Merged
Conversation
jamiecurle
changed the title
Owner
Author
|
I 100% expected these tests to fail, so merging. Fixing them is tomorrows job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual stream is finished, but I think I can do better with this codebase. Ideally push me to the edge of my abilities and set some new personal bests for quality and design.
This PR adds in credo and dialyzer and wires them up with an alias in
mix.exssp that I can runmix checkfor a full report of what's flagged.Also added is a GH action to run tests on every push.
As I go forward all PR's will have to be green before I merge them.