When loading tests, check if the test directory exists.#42
Open
elliotboney wants to merge 3 commits intojayhealey:masterfrom
elliotboney:master
Open
When loading tests, check if the test directory exists.#42elliotboney wants to merge 3 commits intojayhealey:masterfrom elliotboney:master
elliotboney wants to merge 3 commits intojayhealey:masterfrom
elliotboney:master
Conversation
…ncaught exception if you have a test type in one site, and not another.
Author
|
This also would close #35 |
Collaborator
|
This is a great PR which I'd love to merge - but it's got unrelated fixes/changes involved. Could you: so there's a branch containing only that fix, I can then merge the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents an uncaught exception if you have a test type in one site, and not another.
As an example, in Site #A, a user has an "acceptance" suite that they don't have in Site #B. When Codeception loadTests() is called, it iterates through the 'tests' array in config, in each site directory, and crashes if the directory doesn't exist.
Let me know if this needs more clarification.