Added Option for drawing chart lines dashed#18
Open
JCarstens wants to merge 2 commits intojcoglan:masterfrom
Open
Added Option for drawing chart lines dashed#18JCarstens wants to merge 2 commits intojcoglan:masterfrom
JCarstens wants to merge 2 commits intojcoglan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added methods and variables to allow generic dashing of lines in the framework.
A simple method for trying this out is adding dash styles to a line plot (I think my changes only work with them, haven't investigated other plots further) like this:
plot.replace_dash_styles([[5, 5],[9999]]);
The first dash style means 5 pixels line then 5 pixels space and so on, the second one is a solid line. In general, dashing styles work pretty similar to colors. If you want the dashing shown in the legend, you have to set the new line_legend option to true.
Please write me if you have any further questions and thanks for creating this great framework in the first place. :)