Getting it to work on ACAD 2017+#3
Getting it to work on ACAD 2017+#3thelegendofbrian wants to merge 3 commits intojdsandifer:masterfrom
Conversation
There was a problem hiding this comment.
Regarding the first commit: It's been a long time since I worked on this and I don't have an AutoCAD environment now to test things, but are you sure you're correctly adding a list to each test when you create the tests?
The documentation for the defineTest function says that expressions should be a list. It seems like that should work correctly with the foreach. (And wouldn't work correctly with an eval.)
(Making defineTest automatically turn a single expression into a list or otherwise correctly handle a single expression might be a nice feature, but I think we need to be able to handle multiple expressions, too.)
jdsandifer
left a comment
There was a problem hiding this comment.
Nice work on the timing stuff! Please double-check how you're creating tests as I mentioned above and get back to me about whether that makes things work or not (so we can avoid unnecessary changes if possible).
| | *ALU:testsRun* - counter for total tests run in the current batch | ||
| | *ALU:failMessages* - list of messages to print after testing | ||
| | *ALU:startTime* - date number for start of testing | ||
| | *ALU:startTime* - milliseconds since boot time for start of testing |
There was a problem hiding this comment.
This looks like good stuff, but I don't think it should go in this release file. Could you create a new release file for these changes? v1.1.0 sounds right to me as this is an important change, but shouldn't break anything, right?
| | *ALU:testsRun* - counter for total tests run in the current batch | ||
| | *ALU:failMessages* - list of messages to print after testing | ||
| | *ALU:startTime* - date number for start of testing | ||
| | *ALU:startTime* - milliseconds since boot time for start of testing |
There was a problem hiding this comment.
I can't test these timing change now, but this seems like a good approach. Nice work!
It didn't seem to work for ACAD 2018 or 2020 (tested on C3D vertical). The ACAD
datevariable was silently changed in ACAD 2017+, so it broke the timer functionality.Known issues:
Example success:
Example failure: