-
-
Notifications
You must be signed in to change notification settings - Fork 39
chore(ci): add zizmor workflow for github actions security analysis #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c18c1c9
4b9a846
078575e
7485f8e
a9497ca
b7e029d
087e8dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,9 +27,11 @@ jobs: | |
| fetch-depth: 0 | ||
| submodules: recursive | ||
| token: ${{ secrets.MY_RELEASE_PLEASE_TOKEN }} | ||
| persist-credentials: false | ||
|
Comment on lines
29
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| - uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4 | ||
| with: | ||
| experimental: true | ||
| cache: false | ||
| - run: mise trust --all | ||
| - run: mise run release-plz | ||
| env: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: zizmor | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| paths: [".github/workflows/**"] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| zizmor: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: zizmorcore/zizmor-action@b1d7e1fb5de872772f31590499237e7cce841e8e # v0.5.3 | ||
| with: | ||
| advanced-security: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
persist-credentials: false breaks git push in release workflow
High Severity
Adding
persist-credentials: falseto the checkout step removes the git credentials that thetasks/release-plzscript relies on forgit push --tagsandgit push origin release --force. Thetokenparameter (MY_RELEASE_PLEASE_TOKEN) was specifically passed to the checkout action to persist auth for these downstream git operations. Withpersist-credentials: false, those push commands will fail with authentication errors, breaking the entire release automation.Reviewed by Cursor Bugbot for commit 7485f8e. Configure here.