Add Mock return and test correctly set ref in CommitStatusUpdaterTest#1068
Open
DieAkuteSense wants to merge 1 commit intojenkinsci:masterfrom
Open
Add Mock return and test correctly set ref in CommitStatusUpdaterTest#1068DieAkuteSense wants to merge 1 commit intojenkinsci:masterfrom
DieAkuteSense wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating a possible cause of #1010 I've noticed a missing mock return in
CommitStatusUpdaterTest. Related to this, the tests verified thatref=null, which does not align with the given mock values forcauseData, where the source branch is set to "feature". I've added the missing mock return statement and improved the tests to check for the correctly setref="feature".Unfortunately I have not found a cause for #1010 😞
IntelliJ modified the imports a lot...so the diff looks very confusing.