Fix missing gitlabMergeRequestState for note webhook triggers.#1848
Fix missing gitlabMergeRequestState for note webhook triggers.#1848bluesky-adi wants to merge 3 commits intojenkinsci:masterfrom
Conversation
|
Thanks for the review opportunity! The failing CI appears unrelated to this change (no tests were modified or added). Happy to rebase or adjust if you’d like me to handle CI locally or add a safeguard. |
|
Thanks for the update. This change is logic-only and mirrors existing behavior from The CodeQL failure appears to be related to Java autobuild Happy to adjust or add guidance if a specific build step |
|
I am actually seeing the following in the logs: 10:34:45 [ERROR] COMPILATION ERROR :
10:34:45 [INFO] -------------------------------------------------------------
10:34:45 [ERROR] /home/jenkins/agent/workspace/Plugins_gitlab-plugin_PR-1848/src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/note/NoteHookTriggerHandlerImpl.java:[89,71] incompatible types: com.dabsquared.gitlabjenkins.gitlab.hook.model.State cannot be converted to java.lang.String |
|
Did you actually test this change locally? |
What does this PR do?
Populates the
gitlabMergeRequestStateenvironment variable for Jenkinsbuilds triggered by GitLab Merge Request note (comment) webhooks.
This brings note-triggered builds in line with merge request event triggers.
Testing done
Manual reasoning-based validation.
NoteHookTriggerHandlerImplwithMergeRequestHookTriggerHandlerImplmergeRequestStateinCauseDataAutomated tests were not added because:
Related issue
Fixes #1823