Fix so 'Never rebuild merge requests' feature works

[Osmyslitelny]

I started from this issues #705. The main problem was we get 'update' action not only when State is updated but when State is open (you open MR and add some fix push). After that I found that my closed MR doesn't trigger job. After investigation I got that hook was with Action close, not closed. I think It isn't all problem and issues from this scope (MR and webhooks). But it's more popular cases and I think in the future we should to verify what is State and what is Action, and which rule should compare them.

Fixes #705.

[omehegan]

@Osmyslitelny thanks a lot for working on this! I will build a snapshot and post the link to it in #705 so other folks can try it out.

[mattiasb]

Any chance this could get in soonish? :)

[omehegan]

Trying to trigger the CI again but no luck.

@markyjackson-taulia in #705 I published a snapshot with this fix and folks confirmed that it resolved the issue, so we can probably merge it. Would be nice to get the CI to pass though.

[omehegan]

Test passing now :D

[fmdaboville]

Is this will be merged and release soon ? Thanks

[zottinor]

Hi dears, what is the progress on this issue

[markjacksonfishing]

Someone needs to have the build pass ci. Cannot merge until that happens

[Osmyslitelny]

@omehegan If I get it right, MR haven't problem with CI (сш-fail https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgitlab-plugin/detail/PR-869/31/pipeline connect with master - https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgitlab-plugin/detail/master/195/pipeline , not with current MR) . And there #869 (comment) you said "all right". Are you going to merge it soon? It would me nice. Because it isn't very comfortable keep custom-snapshot-fork into project-jenkins. Different issues with versions and etc.