Add email and display name header injection support - revised from PR #30#124
Merged
sboardwell merged 13 commits intojenkinsci:masterfrom Jan 25, 2024
Merged
Conversation
Contributor
Author
|
@sboardwell Hi could you have a look at this? |
Contributor
Sorry, missed this somehow. Will check in the next few days. Thanks 👍 |
sboardwell
reviewed
Dec 23, 2023
Contributor
sboardwell
left a comment
sboardwell
left a comment
There was a problem hiding this comment.
Looks good. I've added a few nitpicks wrt code styling. Would you be able to add a test as well?
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
| if(forwardedEmail!=null){ | ||
| toReturn.setEmail(r.getHeader(forwardedEmail)); | ||
| } | ||
| if(forwardedDisplayName!=null){ |
Contributor
There was a problem hiding this comment.
Suggested change
| if(forwardedDisplayName!=null){ | |
| if (forwardedDisplayName != null) { |
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Boardwell <sboardwell@cloudbees.com>
Contributor
Author
|
Thank you, I'll have a look what I can test. |
Contributor
Author
|
I added some basic tests |
Contributor
|
I have added automated code formatting to the project to avoid having to think about it. This has caused some conflicts - apologies. Could you resolve them please, or would you like me to do it? |
Contributor
Author
|
It would be great if you could resolve the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revised version from PR #30
Original text: