[WiP] Separate authorization models + add Crowd#37
Open
fbelzunc wants to merge 1 commit intojenkinsci:masterfrom
Open
[WiP] Separate authorization models + add Crowd#37fbelzunc wants to merge 1 commit intojenkinsci:masterfrom
fbelzunc wants to merge 1 commit intojenkinsci:masterfrom
Conversation
29b233d to
134559e
Compare
Member
|
Note that the usage of “authorization” in this plugin is nonstandard, as it is not defining an |
Member
|
Would clash more or less superficially with #40. |
jtnord
suggested changes
Nov 30, 2020
Member
jtnord
left a comment
There was a problem hiding this comment.
looks like this stores a password to Crowd in plain text.
| /** | ||
| * The Crowd application password | ||
| */ | ||
| private String crowdApplicationPassword; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Work in Progress
This is a PR which intends two different things:
SecurityRealm[ X ] Separate authorization models from the
SecurityRealm[ X ] Add crowd authorization model
[ X ] Correct findbugs
[ X ] Add readResolve to migrate the data
[ X ] Create new tests with readResolve
[ X ] More code refractor
I am waiting for the review of the maintainer.
CC @Wadeck