Add configurable LDAP timeout properties#49
Open
filip-daca wants to merge 4 commits intojenkinsci:masterfrom
Open
Add configurable LDAP timeout properties#49filip-daca wants to merge 4 commits intojenkinsci:masterfrom
filip-daca wants to merge 4 commits intojenkinsci:masterfrom
Conversation
d9df588 to
e75c98b
Compare
Contributor
|
Hi @filip-daca, thanks a lot for the PR. Instead of adding additional fields, do you think you could base your solution on environment variables as done in jenkinsci/ldap-plugin#102? This would keep mean less maintenance and helps keep things aligned with the main ldap plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new fields to configure LDAP timeouts. Without it, no timeout was used, which could lead to LDAP connectivity issues causing deadlocks while accessing synchronised user cache provided by Guava.
Verification