OPFService now cleanly closes the socket upon exiting #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OPF service is restarted, the service will come back but the socket will not be created. The old socket itself waits 30 seconds until it is automatically closed, by that time the OPFService is already running again, but the NetworkService will not be instantiated. Therefore svc is now available for the OPFService class and therefore OnShutdown and OnStop will call the Close() function of the NetworkService. OnStop had to be implemented, OnShutdown never seams to be called (maybe only on a real system shutdown?). Also, the NetworkService now waits 4 times 30 seconds when the socket is in use on startup, you'll never know if that is needed :).