Fix git push and remote operations failing on non-HTTPS remote URLs #1314
Open
eranturgeman wants to merge 1 commit into
Open
Fix git push and remote operations failing on non-HTTPS remote URLs #1314eranturgeman wants to merge 1 commit into
eranturgeman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix git operations failing when .git/config remote URL is not HTTPS
Push, BranchExistsInRemote, and RemoveRemoteBranch all resolved the remote URL by reading from .git/config via the remote name. This works when the repo was cloned over HTTPS, but fails in two scenarios:
GitManager already has remoteGitUrl which is guaranteed to be HTTPS — SetRemoteGitUrl explicitly normalizes any non-HTTPS URL to the HTTPS URL returned by the VCS provider API. Fetch was already using RemoteURL: gm.remoteGitUrl correctly; Push, BranchExistsInRemote, and RemoveRemoteBranch inconsistently were not.
The fix makes all three use gm.remoteGitUrl for the actual network connection, consistent with how Fetch already works.