-
Notifications
You must be signed in to change notification settings - Fork 40
Docker curation supprot #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
basel1322
wants to merge
25
commits into
jfrog:dev
Choose a base branch
from
basel1322:docker-curation-supprot
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+544
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7e72df to
493aead
Compare
1ca434f to
ff915c5
Compare
e25245f to
a814b8d
Compare
asafambar
reviewed
Dec 21, 2025
asafambar
approved these changes
Dec 22, 2025
attiasas
requested changes
Dec 29, 2025
Contributor
attiasas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! please take a look at my comments, in addition:
- Update branch to
dev - Make sure tests are passing
cli/docs/flags.go
Outdated
| AddSastRules: components.NewStringFlag(AddSastRules, "Incorporate any additional SAST rules (in JSON format, with absolute path) into this local scan."), | ||
|
|
||
| // Docker flags | ||
| DockerImageName: components.NewStringFlag(DockerImageName, "[Docker] Defines the Docker image name to audit. Uses the same format as Docker client with Artifactory. Examples: 'acme.jfrog.io/docker-local/nginx:1.21' (repository path) or 'acme-docker-local.jfrog.io/nginx:1.21' (subdomain)."), |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's confirm text with Technical writer
77c2f19 to
32bc73c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Command
I added support for running curation checks on Docker images using the following command:
jf ca --image <RT-url>/<repository>/<image>:<tag>Same as docker pull command.
This command allows users to run the curation engine directly on a Docker image stored in Artifactory (or in an upstream remote registry) without pulling the image locally.
How It Works Internally
When the command is executed, the CLI performs the following steps:
Fetch Docker Manifest
The CLI retrieves the image’s manifest and configuration from the registry.
This includes:
Image layers (SHA digests)
Extract and Identify Layers
All layer digests listed in the manifest are collected and treated as “packages” for curation evaluation.
Run Curation Rules on Each Layer
Each layer is checked against the configured policy conditions.
Example:
