Only scan recursively if SCA is requested #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
improvement
github-actions
bot
removed
the
safe to test
2 tasks
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalk007
reviewed
Dec 31, 2025
| // If no workingDirs were provided by the user, we apply a recursive scan on the root repository | ||
| } else if utils.IsScanRequested(utils.SourceCode, utils.ScaScan, auditCmd.ScansToPerform()...) || auditCmd.IncludeSbom { | ||
| // Only in case of SCA scan / SBOM requested and if no workingDirs were provided by the user | ||
| // We apply a recursive scan on the root repository |
Contributor
There was a problem hiding this comment.
remove the second comment the first one understands the why the code itself explains the what
eyalk007
approved these changes
Dec 31, 2025
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....We offer the user option to detect sub directories in the root dir, in order to scan each of them with SCA correctly.
Users can choose not to scan recursevely by providing
--working-dirs=.flag value.This PR improve this logic and will not detect sub directortiesto scan in case only JAS scan requested (i.e no SCA or SBOM)