Add test coverage for parse_edid#3
Closed
Copilot wants to merge 2 commits intofeat-xcb-better-monitorsfrom
Closed
Conversation
Co-authored-by: jholveck <240807535+jholveck@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update detail about monitors on Linux
Add test coverage for parse_edid
Feb 20, 2026
jholveck
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_edidintools.pyhad no test coverage. This PR adds a_make_edidhelper and 12 tests covering all major code paths.Tests added
id_legacyfield construction from packed manufacturer ID + product codemanufacture_week=0xFF)0xFF), display name (0xFC)Helper
_make_edid()constructs a valid 128-byte EDID block with correct checksum, supporting all fields needed by the tests:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.