Skip to content

Target net8.0 as minimum TFM for NuGet package #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 6 commits into from
May 5, 2026
Merged

Target net8.0 as minimum TFM for NuGet package #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a16c06
Target net8.0 as minimum TFM for NuGet package
jonathanpeppers May 5, 2026
f925aa7
Add RollForward=Major to tests, fix blank line in sample
jonathanpeppers May 5, 2026
bd3ba73
Keep net10.0 in Directory.Build.props, override net8.0 where needed
jonathanpeppers May 5, 2026
fdd152a
Fix CI: use RestoreAdditionalProjectSources for sample verification
jonathanpeppers May 5, 2026
366317a
Use $(Version) for sample package reference instead of wildcard
jonathanpeppers May 5, 2026
b9b317a
Merge branch 'main' into jonathanpeppers/nuget-target-net8-0
jonathanpeppers May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Verify NuGet package
run: >
dotnet run --project samples/SortingNetworks.Sample
-p:RestoreSources=$(pwd)/SortingNetworks/bin/Release
-p:RestoreAdditionalProjectSources=$(pwd)/SortingNetworks/bin/Release

- name: Upload artifacts
uses: actions/upload-artifact@v7
Expand Down
2 changes: 2 additions & 0 deletions SortingNetworks.Tests/SortingNetworks.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
<RollForward>Major</RollForward>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion SortingNetworks/SortingNetworks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
Comment thread
jonathanpeppers marked this conversation as resolved.
<PackageId>SortingNetworks.SourceGen</PackageId>
<Description>Source generator for sorting-network-based sorting of small arrays, including depth-13 networks for 27 and 28 channels from arXiv:2511.04107.</Description>
<Authors>Jonathan Peppers</Authors>
Expand Down
4 changes: 2 additions & 2 deletions samples/SortingNetworks.Sample/SortingNetworks.Sample.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
Comment thread
jonathanpeppers marked this conversation as resolved.
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="SortingNetworks.SourceGen" Version="*" />
<PackageReference Include="SortingNetworks.SourceGen" Version="$(Version)" />
</ItemGroup>

</Project>