Skip to content

UI Fixes#117

Open
alondmnt wants to merge 8 commits intojoplin:masterfrom
alondmnt:master
Open

UI Fixes#117
alondmnt wants to merge 8 commits intojoplin:masterfrom
alondmnt:master

Conversation

@alondmnt
Copy link
Collaborator

This PR includes several UI improvements and bug fixes for the Templates plugin dialogs.

Original issue thread: https://discourse.joplinapp.org/t/templates-plugin-kills-the-keyboard/47915

Changes

Bug Fixes

  • Default button for dialogs: Fixed regression where dialog default buttons were not properly set
  • Autofocus for dialogs: Implemented autofocus for template and folder selection dialogs
  • Template selection dropdown: Filter out invalid notes from the template selection dropdown
  • Dialog handle correction: Fixed incorrect variable name for template type selection in user dialogs

Improvements

  • Dialog styling: Enhanced dialog appearance and usability

Files Modified

  • src/index.ts
  • src/utils/defaultTemplates.ts
  • src/utils/dialogHelpers.ts
  • src/utils/folders.ts
  • src/utils/templates.ts
  • src/views/defaultTemplates.ts
  • src/views/templateVariables.ts
  • src/views/webview.css

…ion dialogs

- Added AUTO_FOCUS_SCRIPT to handle autofocus for dropdowns in user dialogs.
- Updated getUserDefaultTemplateTypeSelection, getUserFolderSelection, and getUserTemplateSelection functions to include autofocus functionality.
- Introduced dialogHelpers.ts to encapsulate autofocus logic.
Remove `default: true` from all setButtons calls — the Joplin plugin
API does not support this property (it is silently ignored at runtime).
Fix quote style violations in dialogHelpers.ts and templateVariables.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant