Open
Conversation
Open
Owner
|
What exactly does this fix? Old Minecraft versions not properly specifying UTF-8 for the terminal? It seems like it could have other unintended side-effects, and would mean the development environment is different from a standard one. Unless there is some other context I'm missing. |
Author
|
Specifying the UTF8 as console charset would avoid errored console output on operating systems which does not use UTF8 as its native file encoding (e.g. Windows builds for Simplified Chinese language, as it uses GBK)
This fix applys to any version of Minecraft.
|
Owner
|
Is setting this property commonplace in the Chinese community? Maybe we should adjust something in Paper to avoid needing it on newer versions? I am mainly concerned about inconsistency between dev and standard user environment, and the potential to hide bugs or oversights in plugins. Since this applies to more than just the console. |
Author
|
Yes. This is common as far as I know, and I rarely see charset issues from plugins or server as modern plugins uses UTF8 by default in their code and modern editors like VSCode supports autodetect charset, unlike the old Windows notepad and old days (I remember that I was tired to deal with GBK and UTF8 file conversions). So it is safe to use file.encoding imo. However, it would be good to see a better solution to be used in Paper. To make sure this fix applys to older MC, you may need to do some version checking stuff.
…---Original---
From: "Jason ***@***.***>
Date: Sun, Jul 6, 2025 11:46 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [jpenilla/run-task] fix: potential garbling (PR #61)
jpenilla left a comment (jpenilla/run-task#61)
Is setting this property commonplace in the Chinese community? Maybe we should adjust something in Paper to avoid needing it on newer versions? I am mainly concerned about inconsistency between dev and standard user environment, and the potential to hide bugs or oversights in plugins. Since this applies to more than just the console.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #60