Support for promises when no callback is given#37
Open
reinerBa wants to merge 7 commits intojschyma:masterfrom
Open
Support for promises when no callback is given#37reinerBa wants to merge 7 commits intojschyma:masterfrom
reinerBa wants to merge 7 commits intojschyma:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
Author
|
Until the merge is done you can find my fork for Promise (and with it await) supported here npm i open-fin-ts-js-client-promise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for returning promises, which gives the possibility to use async/await keywords and create a workflow without callback hell.
Added jsdoc to the promise returning methods.
Added the possibility to give an bank url as string to the constructor.